Fix expansions that start from the end of another expansion #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
bug
Rangi42
force-pushed
the
expansion-nesting
branch
from
0a10197 to
25c41e0
Compare
ISSOtm
requested changes
Apr 17, 2021
Rangi42
force-pushed
the
expansion-nesting
branch
2 times, most recently
from
3d3e7ca to
f8c4a80
Compare
Do not free an expansion until its offset is *past* its size. This means potentially freeing a nested stack of expansions all at once. Fixes gbdev#696
Rangi42
force-pushed
the
expansion-nesting
branch
from
f8c4a80 to
31f42d8
Compare
ISSOtm
approved these changes
Apr 17, 2021
|
'tis a surprisingly simple fix to an issue that seemed very complex to handle 🤷♂️ |
|
I think it's only possible because now there's maximum 1 lookahead, and it only needs to be aware of one expansion nesting at a time. Previously |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not free an expansion until its offset is past its size. This means potentially freeing a nested stack of expansions all at once.
Fixes #696