Can define exceptions for missing requires

gberaudo · Dec 5, 2017 · b05a5b5 · b05a5b5
1 parent 85d36da
commit b05a5b5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -27,7 +27,8 @@ In a dedicated eslintrc file .eslintrc-googshift.yaml:
     'googshift/no-duplicate-requires': 'error',
 
     'googshift/no-missing-requires': ['error', {
-      prefixes: ['app', 'ol', 'ngeo']
+      prefixes: ['app', 'ol', 'ngeo'],
+      exceptions: ['ngeo.module.requires.push']
     }],
 
     'googshift/no-unused-requires': 'error',

diff --git a/no-missing-requires.js b/no-missing-requires.js
@@ -26,6 +26,7 @@ exports.rule = {
   create: function(context) {
     const defined = {};
     const prefixes = context.options[0].prefixes || ['ol'];
+    const exceptions = context.options[0].exceptions || [];
     const joined = prefixes.join('|');
     const CONST_RE = new RegExp(`^((?:${joined})(\\.[a-z]\\w*)*)\\.[A-Z]+_([_A-Z])+$`);
     const CLASS_RE = new RegExp(`^((?:${joined})(\\.[a-z]\\w*)*\\.[A-Z]\\w*)(\\.\\w+)*$`);
@@ -70,7 +71,7 @@ exports.rule = {
 
         if (parent.type !== 'MemberExpression') {
           const name = util.getName(expression);
-          if (name && STARTS_WITH.test(name) && !defined[name]) {
+          if (name && STARTS_WITH.test(name) && !defined[name] && exceptions.indexOf(name) < 0) {
             // check if the name looks like a const
             let match = name.match(CONST_RE);
             if (match) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-googshift",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "description": "Custom ESLint rules for checking Google Compiler projects",
   "main": "index.js",
   "repository": {