Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: avoid to use Caddy duration as pointer. #26

Merged
merged 1 commit into from
May 3, 2022

Conversation

vuongxuongminh
Copy link
Member

No description provided.

@vuongxuongminh vuongxuongminh changed the title refactor!: avoid to use caddy duration as pointer. refactor!: avoid to use Caddy duration as pointer. May 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #26 (e3a2750) into main (e018fd2) will increase coverage by 0.24%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   75.06%   75.31%   +0.24%     
==========================================
  Files          24       24              
  Lines        1909     1908       -1     
==========================================
+ Hits         1433     1437       +4     
+ Misses        362      358       -4     
+ Partials      114      113       -1     
Impacted Files Coverage Δ
caddyfile.go 42.65% <0.00%> (+0.58%) ⬆️
handler.go 76.13% <100.00%> (-0.27%) ⬇️
schema_fetcher.go 85.65% <100.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57743b...e3a2750. Read the comment docs.

@vuongxuongminh vuongxuongminh merged commit d4af2df into main May 3, 2022
@vuongxuongminh vuongxuongminh deleted the avoid-to-use-caddy-duration-as-pointer branch May 3, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants