Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loaded Android Gradle Plugin Conditionally #14

Merged
merged 1 commit into from
Aug 28, 2023
Merged

loaded Android Gradle Plugin Conditionally #14

merged 1 commit into from
Aug 28, 2023

Conversation

SaeedZhiany
Copy link
Contributor

This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:

if (project == rootProject) {
    // ... (dependency here)
}

The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).

for more info, you can refer to this thread and especially this comment.

@gbumps gbumps merged commit bdaabb4 into gbumps:master Aug 28, 2023
@gbumps
Copy link
Owner

gbumps commented Aug 28, 2023

LGTM, done, will be in next release soon.

Thanks for the contribution!

Repository owner locked as resolved and limited conversation to collaborators Aug 28, 2023
@SaeedZhiany SaeedZhiany deleted the patch-1 branch August 28, 2023 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants