Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New File in Directory Formate leads to an issue #17

Closed
moehrlich opened this issue Jan 28, 2019 · 3 comments
Closed

New File in Directory Formate leads to an issue #17

moehrlich opened this issue Jan 28, 2019 · 3 comments
Labels
enhancement New feature or request fixed Issue is fixed

Comments

@moehrlich
Copy link
Collaborator

If you accidentaly add an new file to the Formate Directory the system does not know what it has to do with that file and did not starts correctly. It should ignore these file or should show a error message.

@EliDeh
Copy link
Collaborator

EliDeh commented Mar 22, 2019

A error message will be added

@EliDeh EliDeh added the enhancement New feature or request label Mar 22, 2019
@EliDeh EliDeh added the fixed on dev Issue is fixed on the dev branch label Jul 24, 2019
@jsubhi
Copy link
Collaborator

jsubhi commented Aug 8, 2019

Non-json Files are ignored now - good. But any invalid json file in the Formate directory seems to force default values on all other settings in the program. The settings in config.json and all the formats no longer apply.
This behaviour can be reproduced by adding an empty "test.json" to Formate or by adding an extra comma to default_gross.json for example.
Not a major issue but a more robust handling would be nice, e.g. quitting with "invalid configuration in test.json"

EliDeh added a commit that referenced this issue Aug 26, 2019
@jsubhi
Copy link
Collaborator

jsubhi commented Sep 3, 2019

Looks good now. Thanks!

@jsubhi jsubhi closed this as completed Sep 3, 2019
@EliDeh EliDeh added fixed Issue is fixed and removed fixed on dev Issue is fixed on the dev branch labels Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Issue is fixed
Projects
None yet
Development

No branches or pull requests

3 participants