Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex should also cover SST-Field #60

Closed
jsubhi opened this issue May 13, 2019 · 1 comment
Closed

Regex should also cover SST-Field #60

jsubhi opened this issue May 13, 2019 · 1 comment
Labels
enhancement New feature or request fixed Issue is fixed

Comments

@jsubhi
Copy link
Collaborator

jsubhi commented May 13, 2019

There should be an option to apply a regex-based filter also to the "Sonderstandort" Field (7100 $f / 209A $f).
Preferably this would be a separte regex that is tested first, before the main regex is tested. If this field is left empty it should match any signature.

Probably there is no nee to support capture groups ($1, $2 etc) for this field - it would be used just as a filter.

@jsubhi jsubhi added the enhancement New feature or request label May 13, 2019
EliDeh added a commit that referenced this issue Jul 30, 2019
@EliDeh EliDeh added the fixed on dev Issue is fixed on the dev branch label Jul 30, 2019
@jsubhi
Copy link
Collaborator Author

jsubhi commented Aug 8, 2019

Works as expected so far. Makes creating some signature regexes much easier!

@jsubhi jsubhi closed this as completed Aug 8, 2019
@EliDeh EliDeh added fixed Issue is fixed and removed fixed on dev Issue is fixed on the dev branch labels Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Issue is fixed
Projects
None yet
Development

No branches or pull requests

2 participants