Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced/useless PURE comments with latest vite/rollup #1926

Closed
AlexGalays opened this issue Mar 13, 2024 · 1 comment
Closed

Misplaced/useless PURE comments with latest vite/rollup #1926

AlexGalays opened this issue Mar 13, 2024 · 1 comment

Comments

@AlexGalays
Copy link

When building an app using fp-ts, we get a lot of warnings because of misplaced PURE comments in a few files.
The lib works, it's just distracting to see this everytime :)

../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/IOEither.js (656:0) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/IOEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderIO.js (23:20) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderIO.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderEither.js (624:0) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTask.js (28:22) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTask.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js (26:28) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js (87:27) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js (92:26) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js (991:0) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/ReaderTaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/StateReaderTaskEither.js (773:0) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/StateReaderTaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/TaskThese.js (69:26) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/TaskThese.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/TaskEither.js (962:0) A comment

"/*#__PURE__*/"

in "../../.yarn/cache/fp-ts-npm-2.16.3-31e1c8b029-24f071a4a6.zip/node_modules/fp-ts/es6/TaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
gcanti added a commit that referenced this issue Mar 18, 2024
@gcanti gcanti closed this as completed in 7e70370 Mar 18, 2024
@gcanti
Copy link
Owner

gcanti commented Mar 18, 2024

Should be fixed in 2.16.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants