Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Array module documentation #1631

Merged
merged 7 commits into from
Dec 7, 2021
Merged

Improving Array module documentation #1631

merged 7 commits into from
Dec 7, 2021

Conversation

fmpanelli
Copy link
Contributor

Adding descriptions and examples for several functions of the Array module.
My aim is to make the awesome fp-ts library a bit more accessible to users and to beginners in particular.

No changes have been done to the actual code.

Thanks in advance for every feedback and input for additional improvement.

Filippo

Adding descriptions and examples for several
functions of the Array module.
Copy link
Collaborator

@grossbart grossbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very helpful, I think! Please have a look at my comments and fix them, if you agree. After that I would suggest to merge this.

src/Array.ts Show resolved Hide resolved
src/Array.ts Outdated Show resolved Hide resolved
src/Array.ts Outdated Show resolved Hide resolved
src/Array.ts Outdated Show resolved Hide resolved
src/Array.ts Outdated Show resolved Hide resolved
src/Array.ts Show resolved Hide resolved
src/Array.ts Outdated Show resolved Hide resolved
src/Array.ts Show resolved Hide resolved
src/Array.ts Show resolved Hide resolved
src/Array.ts Show resolved Hide resolved
fmpanelli and others added 5 commits December 6, 2021 20:42
Co-authored-by: Peter Gassner <peter@gassner.io>
Co-authored-by: Peter Gassner <peter@gassner.io>
Co-authored-by: Peter Gassner <peter@gassner.io>
@fmpanelli
Copy link
Contributor Author

Included all improvements suggested by @grossbart , thank you!

@grossbart grossbart merged commit ee7c1da into gcanti:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants