relax UnknownRecord check, closes #559

gcanti · Feb 3, 2021 · eedc197 · eedc197
1 parent cd5a1b0
commit eedc197
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Guard.ts b/src/Guard.ts
@@ -93,7 +93,7 @@ export const UnknownArray: Guard<unknown, Array<unknown>> = {
  * @since 2.2.0
  */
 export const UnknownRecord: Guard<unknown, Record<string, unknown>> = {
-  is: (u: unknown): u is Record<string, unknown> => Object.prototype.toString.call(u) === '[object Object]'
+  is: (u: unknown): u is Record<string, unknown> => u != null && typeof u === 'object' && !Array.isArray(u)
 }
 
 // -------------------------------------------------------------------------------------

diff --git a/test/Guard.ts b/test/Guard.ts
@@ -1,6 +1,7 @@
 import * as assert from 'assert'
 import * as G from '../src/Guard'
 import { pipe } from 'fp-ts/lib/pipeable'
+import { Stream } from 'stream'
 
 interface NonEmptyStringBrand {
   readonly NonEmptyString: unique symbol
@@ -281,4 +282,16 @@ describe('Guard', () => {
       assert.deepStrictEqual(guard.is({ _tag: 2, b: 'a' }), false)
     })
   })
+
+  describe('UnknownRecord', () => {
+    it('should accept valid inputs', () => {
+      assert.strictEqual(G.UnknownRecord.is(new Set()), true)
+      assert.strictEqual(G.UnknownRecord.is(new Map()), true)
+      assert.strictEqual(G.UnknownRecord.is(new Stream()), true)
+    })
+
+    it('should reject invalid inputs', () => {
+      assert.strictEqual(G.UnknownRecord.is([]), false)
+    })
+  })
 })