[Feature] Update verbosity arguments to accept int or bool in getrawtransaction and searchrawtransactions

[zquestz]

Updated the remaining Verbose/Verbosity arguments found in the RPC to handle either int or bool values. This fixes the last quirk mentioned in #385.

The updated methods were:

• getrawtransaction
• searchrawtransactions

Note: there is some important naming.

VerbosityLevel allows [0,1,2,true,false] to support getblock
VerboseLevel allows [0,1,true,false] to support getrawtransaction and searchrawtransactions.

Here is some sample working curl calls.

curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "getrawtransaction", "params": ["9d7cb019c6cdba505193a70e60d59b8f2145afa79065c957e05c6389630249b0"] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "getrawtransaction", "params": ["9d7cb019c6cdba505193a70e60d59b8f2145afa79065c957e05c6389630249b0",0] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "getrawtransaction", "params": ["9d7cb019c6cdba505193a70e60d59b8f2145afa79065c957e05c6389630249b0",1] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "getrawtransaction", "params": ["9d7cb019c6cdba505193a70e60d59b8f2145afa79065c957e05c6389630249b0",true] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "getrawtransaction", "params": ["9d7cb019c6cdba505193a70e60d59b8f2145afa79065c957e05c6389630249b0",false] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "searchrawtransactions", "params": ["bitcoincash:qrhea03074073ff3zv9whh0nggxc7k03ssh8jv9mkx"] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "searchrawtransactions", "params": ["bitcoincash:qrhea03074073ff3zv9whh0nggxc7k03ssh8jv9mkx",0] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "searchrawtransactions", "params": ["bitcoincash:qrhea03074073ff3zv9whh0nggxc7k03ssh8jv9mkx",1] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "searchrawtransactions", "params": ["bitcoincash:qrhea03074073ff3zv9whh0nggxc7k03ssh8jv9mkx",false] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "searchrawtransactions", "params": ["bitcoincash:qrhea03074073ff3zv9whh0nggxc7k03ssh8jv9mkx",true] }' -k

Invalid calls.

curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "getrawtransaction", "params": ["9d7cb019c6cdba505193a70e60d59b8f2145afa79065c957e05c6389630249b0",2] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "getrawtransaction", "params": ["9d7cb019c6cdba505193a70e60d59b8f2145afa79065c957e05c6389630249b0","bad"] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "searchrawtransactions", "params": ["bitcoincash:qrhea03074073ff3zv9whh0nggxc7k03ssh8jv9mkx",2] }' -k
curl --header "Content-Type: application/json" https://127.0.0.1:8334/ -d '{ "jsonrpc": "2.0", "id":   1, "method": "searchrawtransactions", "params": ["bitcoincash:qrhea03074073ff3zv9whh0nggxc7k03ssh8jv9mkx","bad"] }' -k

@cculianu you can test and make sure it fixes the issue you brought up. =)

[cculianu]

Ok @zquestz -- I will test it today after coffee and let you know!

[cculianu]

Yep. It works. Tested with Fulcrum after removing the quirks codepath for this. (Thus sending false always). Thumbs up!

EDIT: Also tested with the quirk codepath enabled -- that is both int and bool work with Fulcrum now (although to be simplest once this lands Fulcrum will just always send bool).