Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__attribute__((fallthrough)) with braces #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

__attribute__((fallthrough)) with braces #22

wants to merge 1 commit into from

Conversation

Kochise
Copy link

@Kochise Kochise commented Feb 6, 2018

Accept braces (cases 12 and 13)

Accept braces (cases 12 and 13)
@Kochise Kochise changed the title Compatibility with different syntaxes __attribute__((fallthrough)) with braces Feb 6, 2018
@jwakely
Copy link
Contributor

jwakely commented Feb 12, 2018

This is an unofficial mirror that nobody from the GCC project is involved with. Sending pull requests here is a waste of time.

Please see https://gcc.gnu.org/contribute.html for how to contribute to GCC, thanks.

@Kochise
Copy link
Author

Kochise commented Feb 24, 2018

Then what's the point to have a GitHub presence if nothing can be done from there since "nobody from the GCC project is involved with" as you put it mildly ? Regarding the link, it starts with an annoying "Legal Prerequisites" stating that "FSF prefers that a contributor files a copyright assignment". If that's the way the mighty FSF welcomes contributors, it, in contrary, effectively turns me down and puts an end to my willing collaboration and hence they might receive my warmest finger salute.

@jwakely
Copy link
Contributor

jwakely commented Feb 24, 2018

Then what's the point to have a GitHub presence if nothing can be done from there

You seem to be missing the point that this mirror was created by an unknown person who has nothing to do with the GCC project. Anybody can create a fork of any open source Git repo and host it on github. This is not "a Github presence" for the GCC project, it's just a repo created by a person on the internet.

If you don't want to contribute to GCC that's fine, there's no need to be rude about it.

@Kochise
Copy link
Author

Kochise commented Feb 25, 2018

Something called gcc-mirror and mirroring the official repo looks legit enough to be thought having some affiliation with the original content, hence my believing participating here might have some impact on the other side of the bridge it is connected to. If not, I see no point to this repo and getting people fooled into something that is then just a scam.

Should I warn the gcc guys and github staff about this place ?

@stefanos82
Copy link

@Kochise you don't have to sign anything.

The following paragraph from contribute page makes it clear for you:

If a contributor is reluctant to sign a copyright assignment for a change, a copyright disclaimer to put the change in the public domain is acceptable as well. The copyright disclaimer form is different than an employer disclaimer form. A copyright assignment is more convenient if a contributor plans to make several separate contributions.

Small changes can be accepted without a copyright disclaimer or a copyright assignment on file.

@abhiTronix
Copy link

Should I warn the gcc guys and github staff about this place ?

@Kochise How did it go?

@Kochise
Copy link
Author

Kochise commented Oct 3, 2019

Dunno, I abandoned all hope into gcc and carried on another more faithful path.

kraj pushed a commit to kraj/gcc that referenced this pull request Jun 8, 2022
This is the first pass at implementing macros more testcases are needed.

This does not support repetition matchers but it supports simple
declarative macros and transcribes them. The approach taken here is that
we reuse our existing parser to call the apropriate functions as specified
as part of the MacroFragmentType enum if the parser does not have errors
parsing that item then it must be a match.

Then once we match a rule we have a map of the token begin/end offsets
for each fragment match, this is then used to adjust and create a new token
stream for the macro rule definition so that when we feed it to the parser
the tokens are already substituted. The resulting expression or item is
then attached to the respective macro invocation and this is then name
resolved and used for hir lowering.

Fixes gcc-mirror#17 gcc-mirror#22
Addresses #573
kraj pushed a commit to kraj/gcc that referenced this pull request Jun 8, 2022
938: First pass at declarative macro expansion  r=philberty a=philberty

This does not support repetition matchers but it supports simple
declarative macros and transcribes them. The approach taken here is that
we reuse our existing parser to call the apropriate functions as specified
as part of the MacroFragmentType enum if the parser does not have errors
parsing that item then it must be a match.
    
Then once we match a rule we have a map of the token begin/end offsets
for each fragment match, this is then used to adjust and create a new token
stream for the macro rule definition so that when we feed it to the parser
the tokens are already substituted. The resulting expression or item is
then attached to the respective macro invocation and this is then name
resolved and used for hir lowering.
    
Fixes gcc-mirror#17 gcc-mirror#22
Addresses #573

Co-authored-by: Philip Herron <philip.herron@embecosm.com>
aurxenon pushed a commit to aurxenon/gcc that referenced this pull request Sep 11, 2023
Add support for const attribute in libgccjit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants