Fixed constraints on operator<=>(optional<T>, U) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operator<=>(std::optional<_Tp>,_Up) was underconstrained. _Up needs to fulfill std::three_way_comparable<_Tp>. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98842 and http://eel.is/c++draft/optional#comp.with.t-25.
|
This is an unofficial read-only mirror. Creating pull requests here is a waste of time. Also, your change fails the testsuite. |
|
It was fixed properly by adec148 |
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jun 8, 2022
This adds type inferencing and validation for arrays such as: let x: [i32, 5] = [1,2,3,4,5] ley y = [1,2,3]; It checks that each element is of a valid type and they line up correctly. There needs to be some refactoring of the type resolution to handle the array index expressions so this is a good save point for now. Addresses: gcc-mirror#27 gcc-mirror#55
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jun 8, 2022
Adds new TypeVisitor to resolve Types from the AST via Visitor Pattern, so the element type can be extracted. Addresses: gcc-mirror#27 gcc-mirror#55
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jun 8, 2022
The index expression must be validated to ensure it is an integer. Addresses: gcc-mirror#27 gcc-mirror#55
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jun 8, 2022
This compiles the ArrayIndexExpressions and Arrays such as: let x = [1,2,3]; let a = x[0]; Addresses: gcc-mirror#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator<=>(std::optional<_Tp>,_Up) was underconstrained. _Up needs to fulfill std::three_way_comparable<_Tp>. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98842 and http://eel.is/c++draft/optional#comp.with.t-25.