Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for MAGIC in server response #14

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Test for MAGIC in server response #14

merged 4 commits into from
Jun 26, 2020

Conversation

d98762625
Copy link
Member

added failing MAGIC test which we can verify works later (expectedOutput will have to be changed)

@d98762625 d98762625 marked this pull request as draft May 28, 2020 13:08
@d98762625 d98762625 changed the title WIP: Test for MAJIC in server response WIP: Test for MAGIC in server response May 28, 2020
@d98762625
Copy link
Member Author

d98762625 commented Jun 12, 2020 •
edited
Loading

With the PR to allow magic in the Node API, flowControl operations are not currently valid in bake recipes. We will need to add a separate endpoint specifically to run magic on some input in the API.

Propose we expose /magic where you can similarly POST some input plus optional arguments for magic operation and receive JSON of the output of Magic.

@d98762625
Copy link
Member Author

TODO update readme

@d98762625 d98762625 changed the title WIP: Test for MAGIC in server response Test for MAGIC in server response Jun 26, 2020
@d98762625 d98762625 marked this pull request as ready for review June 26, 2020 13:22
@d98762625 d98762625 merged commit 5aae898 into master Jun 26, 2020
@d98762625 d98762625 deleted the allow-magic branch July 3, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d98762625