Add ChaCha stream cipher operation #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joostrijneveld
force-pushed
the
feature/chacha
branch
from
3b887b8 to
ebe2a29
Compare
|
Brilliant, thanks very much for the contribution. Poly1305 and/or Salsa20 operations would be welcomed if you fancy it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ChaCha stream cipher. I've chosen to support both the 'original construction' and ChaCha20 as specified in RFC-8439 (i.e., with a 32-bit instead of a 64-bit counter). Poly1305 may follow separately; I considered whether to combine the two in a single operation, but decided that ChaCha would be of individual interest.
I claim no proficiency in Javascript, and am happy to take any pointers (especially related to type conversions). In particular, this pull request also adds functions to the Utils module to convert between integers and bytes (much like Python's
int.to_bytesandint.from_bytes) ― I was unable to find built-in functionality for this.