Fix ChaCha operation Raw output #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an array type error prevented any output when selecting the 'Raw' output option for the ChaCha operation. This did not show up in tests, as they all compared to hex values. This also adds a test (relying on the 'To Hex' operation) that catches this.
|
Thanks for the fix :) |
mwalbeck
pushed a commit
to mwalbeck/docker-cyberchef
that referenced
this pull request
Apr 6, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gchq/CyberChef](https://github.com/gchq/CyberChef) | minor | `v10.12.1` -> `v10.15.1` | --- ### Release Notes <details> <summary>gchq/CyberChef (gchq/CyberChef)</summary> ### [`v10.15.1`](https://github.com/gchq/CyberChef/releases/tag/v10.15.1) [Compare Source](gchq/CyberChef@v10.15.0...v10.15.1) See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details. ### [`v10.15.0`](https://github.com/gchq/CyberChef/releases/tag/v10.15.0) [Compare Source](gchq/CyberChef@10.14.0...v10.15.0) See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details. ### [`v10.14.0`](https://github.com/gchq/CyberChef/releases/tag/v10.14.0) [Compare Source](gchq/CyberChef@10.14.0...10.14.0) See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details. ### [`v10.14.0`](https://github.com/gchq/CyberChef/blob/HEAD/CHANGELOG.md#10140---2024-03-31) [Compare Source](gchq/CyberChef@v10.13.0...10.14.0) - Added 'To Float' and 'From Float' operations \[[@​tcode2k16](https://github.com/tcode2k16)] | \[[#​1762](gchq/CyberChef#1762)] - Fix ChaCha raw export option \[[@​joostrijneveld](https://github.com/joostrijneveld)] | \[[#​1606](gchq/CyberChef#1606)] - Update x86 disassembler vendor library \[[@​evanreichard](https://github.com/evanreichard)] | \[[#​1197](gchq/CyberChef#1197)] - Allow variable Blowfish key sizes \[[@​cbeuw](https://github.com/cbeuw)] | \[[#​933](gchq/CyberChef#933)] - Added 'XXTEA' operation \[[@​devcydo](https://github.com/devcydo)] | \[[#​1361](gchq/CyberChef#1361)] ### [`v10.13.0`](https://github.com/gchq/CyberChef/releases/tag/v10.13.0) [Compare Source](gchq/CyberChef@v10.12.1...v10.13.0) See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMyIsInVwZGF0ZWRJblZlciI6IjM3LjI3OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Reviewed-on: https://git.walbeck.it/mwalbeck/docker-cyberchef/pulls/286 Co-authored-by: renovate-bot <bot@walbeck.it> Co-committed-by: renovate-bot <bot@walbeck.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, an array type error prevented any output when selecting the 'Raw' output option for the ChaCha operation. This did not show up in tests, as they all compared to hex values.
This pull request also adds a test that catches this (relying on the existing
'To Hex'operation).