-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Use recommended GitHub Actions to build image #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
As always with CI/CD stuff, there's some testing that needs to be done, testing that is hard for contributors to do. |
oci: true | ||
# Webpack seems to use a lot of open files, increase the max open file limit to accomodate. | ||
extra-args: | | ||
--ulimit nofile=10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen this issue with the docker actions myself, so let's hope it's not still an issue.
- The redhat actions no longer provide anything not provided by the official docker action - The redhat action creates OCI images that are not following best practices from the OCI specification
bb36316
to
967f93a
Compare
registry: ${{ env.REGISTRY }} | ||
username: ${{ env.REGISTRY_USER }} | ||
password: ${{ env.REGISTRY_PASSWORD }} | ||
|
||
- name: Publish to GHCR | ||
uses: docker/build-push-action@v6 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two additional options worth noting:
sbom: true
- builds and includes a SBOM attestation for the image to help tools correlate the contents of the imageprovenance: mode=max
: - includes a provenance attestation to help tools correlate the origin of the image
Use the recommended GitHub Actions to build the Docker image.
There are at least a couple of reasons to do so:
1 the latest CyberChef OCI image's list manifest lacks the
mediaType
property referenced in the OCI specification. Compliant implementations SHOULD implement it to ensure compatibility.Full CyberChef manifest for reference