Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Play Audio" Operation #357

Closed
wants to merge 2 commits into from
Closed

Add "Play Audio" Operation #357

wants to merge 2 commits into from

Conversation

GCHQ77703
Copy link
Member

Adds the ability to render a media data URI into a playable audio file. These look something like this. To get this into something that's playable we parse the data URI for it's type and convert the rest into binary data. We then create a blob from this data and from that blob we can create a blob URI which is a valid src on an audio element.

Creating this from the File type would seem simple following that logic, as it is just an extension to a Blob. Unfortunately, this is not the case because it appears Dish.mjs doesn't persist the type of a file (nor could I see a way of it doing so, especially due to the MIME type possibly changing through processing).

@n1474335
Copy link
Member

Rather than requiring a data URI as input, would it be possible to just accept a byteArray or ArrayBuffer in a similar way to the 'Render Image' operation? This would be more useful when manipulating and decrypting data. It's more likely that an audio file will be found than a data URI specifically.

@n1474335
Copy link
Member

This has been addressed in #446, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants