-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Parse CSR" #381
Add "Parse CSR" #381
Conversation
arnydo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, @arnydo . Could you add some test cases to cover this operation?
src/core/operations/ParseCSR.mjs
Outdated
Country: ${csr.subject.getField("C").value} | ||
EmailAddress: ${csr.subject.getField("E").value} | ||
Subject Alternative Names: ${subjectAltNames.map(function (name) { | ||
return name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this map
return benefit from some formatting? Rather than having all subjectAltNames
being listed with no separator.
Hi @arnydo, this looks great but I'm having trouble getting any example CSRs to parse correctly. Could you take a look and include some tests please? |
Ah! It looks like it is expecting specific extensions to be present (subjectAltNames, etc). Ill work on adding some conditions... |
Hi @arnydo, are you still intending on working on this? |
Hi @n1474335 I haven't had a chance to dig into this and if others don't seem to have a need for it then we can drop it. |
Closed as stale |
Operation to parse Certificate Signing Requests for basic information: