Add QR code generation and parsing #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add presentation of QR code in HTML.
|
Awesome work! I've made a number of modifications, largely around stylistic conventions and a few areas where there are available helper functions or code could be simplified a bit. Thanks for sorting this one out, I know a lot of people will find it useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new operations, "Generate QR Code" and "Parse QR Code", requested in #259 .
Parse QR Code has a normalise image option, which attempts to make the image easier to read by the QR reader module (jsQR), as otherwise things like transparent images can cause it to fail.
As we're using the Jimp module to read and process the images, we can potentially add other image manipulation operations in the future to better utilise it.