Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddNamedOperation should not default any Access Control information #2476

Closed
m29827 opened this issue Jul 14, 2021 · 0 comments · Fixed by #2477
Closed

AddNamedOperation should not default any Access Control information #2476

m29827 opened this issue Jul 14, 2021 · 0 comments · Fixed by #2477
Assignees
@m29827
Labels
bug Confirmed or suspected bug named-operation Specific to/touches Named Operations
Milestone
v1.19.0

Comments

@m29827
Copy link
Member

m29827 commented Jul 14, 2021

Discovered while updating documentation for Access Controlled Resources (gchq/gaffer-doc#219). AddNamedOperation should not default empty arrays for readAccessRoles and writeAccessRoles, these are mutually exclusive with the readAccessPredicate and writeAccessPredicate properties and should be null by default.
@m29827 m29827 self-assigned this Jul 14, 2021
@m29827 m29827 added the bug Confirmed or suspected bug label Jul 14, 2021
m29827 added a commit to m29827/Gaffer that referenced this issue Jul 14, 2021
@m29827
gchqgh-2476 Stop defaulting access roles to empty arrays. Read and Wr…
3109a71 
…ite access role properties are mutually exclusive with read and write AccessPredicate properties.
@m29827 m29827 mentioned this issue Jul 14, 2021
Closed
@m29827 m29827 linked a pull request Jul 14, 2021 that will close this issue
gh-2476 Stop defaulting access roles to empty arrays. #2477
Merged
m29827 added a commit to m29827/Gaffer that referenced this issue Jul 14, 2021
@m29827
gchqgh-2476 Stop defaulting access roles to empty arrays. Read and Wr…
85074a3 
…ite access role properties are mutually exclusive with read and write AccessPredicate properties.
@n3101 n3101 added the named-operation Specific to/touches Named Operations label Jul 21, 2021
m29827 added a commit to m29827/Gaffer that referenced this issue Aug 3, 2021
@m29827
gchqgh-2476 Code review comments
2fe413d
t92549 added a commit to m29827/Gaffer that referenced this issue Aug 23, 2021
@t92549
Merge branch 'develop' into gchqgh-2476-stop-defaulting-access-roles
27088c2
@t92549 t92549 added this to the v1.19.0 milestone Aug 23, 2021
t92549 pushed a commit that referenced this issue Aug 23, 2021
@m29827
gh-2476 Stop defaulting access roles to empty arrays. (#2477)
d2f737c 
* gh-2476 Stop defaulting access roles to empty arrays. Read and Write access role properties are mutually exclusive with read and write AccessPredicate properties.

* gh-2476 Code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m29827 m29827

Labels
bug Confirmed or suspected bug named-operation Specific to/touches Named Operations
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging a pull request may close this issue.

gh-2476 Stop defaulting access roles to empty arrays. m29827/Gaffer
3 participants
@n3101 @m29827 @t92549