-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create endpoint to get Gaffer version #2837
Comments
Its unfortunate but upon inspection of the PR the ticket is not correct. The approach likely should be a Operation and Handler to get the version, which can then be delegated to individual graphs using a normal |
Isn't that a separate feature? It seems like from the original ticket its just the API version of what you are interacting with that should be returned which if it was a federated system would still work and just be the version of the graph configured with a federated store. |
An operation to get the Gaffer version is a separate, but related feature. An operation could be federated to a remote graph, which might be running a different version of Gaffer to the version running the REST API a user is directly interacting with. This comment explains further, but for getting the store type. A The endpoint will always return the version of Gaffer used by the REST instance. This is less useful than an operation which can be used to determine the version of Gaffer used by remote stores. However, if the endpoint is a Proxy Store, then any operations sent to it will always be processed by the remote store it's connected to. So using only an operation, it wouldn't be possible to get the Gaffer version used by a Proxy Store REST endpoint itself. The situation would be the same for a Federated Store endpoint which federated only to remote graphs. I think that an operation would also be useful, and an endpoint would not be redundant, they would not have identical functionality. |
* Add spring endpoint for getting the version * Create endpoint for jersey API * update tests to add version validation check via test resource --------- Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
Describe the new feature you'd like
An endpoint added to the rest api to get the api's Gaffer version
Why do you want this feature?
Swagger does give this information but with the upgrade to swagger version, how to get it is inconsistent. It is important to know what Gaffer version an api is running and therefore it would be better if this was provided by the api.
Additional context
This should probably be added to both the spring-rest and core-rest
The text was updated successfully, but these errors were encountered: