Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map store GetAllElements returns matchedVertex on Edge results #2840

Closed
t92549 opened this issue Dec 9, 2022 · 0 comments · Fixed by #3297
Closed

Map store GetAllElements returns matchedVertex on Edge results #2840

t92549 opened this issue Dec 9, 2022 · 0 comments · Fixed by #3297
Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Milestone
Backlog

Comments

@t92549
Copy link
Contributor

t92549 commented Dec 9, 2022 •
edited
Loading

Describe the bug
After a GetAllElements operation when the result is an Edge, the map store returns matchedVertex but the accumulo store does not. Which is correct behaviour and why the difference?

To Reproduce
Add an Edge to a map store backed graph. Do GetAllElements. Result contains "matchedVertex": "SOURCE"

Expected behavior
It probably should not as this is not very useful, it will always match on source for GetAllElements

Additional context
Added a branch with temporary test to show behaviour: 6904676
@t92549 t92549 added the bug Confirmed or suspected bug label Dec 9, 2022
@t92549 t92549 added this to the post-v2.0_backlog milestone Dec 9, 2022
@t92549 t92549 added the map-store Specific to/touches the map-store module label Nov 2, 2023
@github-actions github-actions bot mentioned this issue Sep 16, 2024
Merged
j69772 added a commit that referenced this issue Sep 19, 2024
@j69772
Merge branch 'develop' into gh-2840-mapstore-matchedvertex-inconsistent
d8f829b
p29876 added a commit that referenced this issue Oct 9, 2024
@p29876
Merge branch 'develop' into gh-2840-mapstore-matchedvertex-inconsistent
9bb7925
wb36499 added a commit that referenced this issue Oct 21, 2024
@wb36499
Merge branch 'develop' into gh-2840-mapstore-matchedvertex-inconsistent
be20c5d
wb36499 added a commit that referenced this issue Oct 22, 2024
@wb36499
Merge branch 'develop' into gh-2840-mapstore-matchedvertex-inconsistent
844ad48
wb36499 added a commit that referenced this issue Oct 23, 2024
@wb36499
Merge branch 'develop' into gh-2840-mapstore-matchedvertex-inconsistent
bae522e
wb36499 added a commit that referenced this issue Oct 23, 2024
@j69772 @t92549
@p29876 @wb36499
Gh-2840: MapStore MatchedVertex inconsistent (#3297)
73b7544 
* Added temporary test to show inconsistency

* remove demo test showing inconsistency

* remove duplication

* Remove bug by creating new edge for matched Vertex  SOURCE

* add test to confirm changes

* remove ref to Edge id

* remove public modifier from test

* remove repeated copyright header

* remove unused import

* address comments

* disable failing integration tests - see #3314

I think the map store implementation for MatchedVertex is now correct
We need to investigate the behaviour for Accumulo

* disable test, copyright headers

* try again

* headers

---------

Co-authored-by: t92549 <t92549@users.noreply.github.com>
Co-authored-by: p29876 <165825455+p29876@users.noreply.github.com>
Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Gh-2840: MapStore MatchedVertex inconsistent gchq/Gaffer
1 participant
@t92549