Remove redundant constants class

[GCHQDeveloper314]

The class CommonConstants.java has two static fields. One is unused and the other (UTF-8) is used in various places in Gaffer but can be replaced with an equivalent Java builtin.

Remove this class and replace references to its field with the equivalent Java builtin.

[ibrijesh]

I am interested in contributing, Could you please assign me this task?

I would like to clarify the following changes that need to be made:

1.Remove the file named CommonConstants.java.
2.Replace the line import uk.gov.gchq.gaffer.commonutil.CommonConstants; with import java.nio.charset.StandardCharsets;.
3.Replace all instances of CommonConstants.UTF_8 with StandardCharsets.UTF_8.

[GCHQDeveloper314]

Yes that is correct. You may also need to ensure the import order is correct after replacing the old import, as we have checkstyle rules for enforcing a clean order. You can run the checkstyle checks without needing to do a full build and test of the codebase by using mvn checkstyle:check.

[ibrijesh]

When i am runniing this command mvn checkstyle:check I am getting below error

[GCHQDeveloper314]

It looks like you will need to run mvn clean install -Pquick first, in order to build the project dependencies.

[ibrijesh]

Getting this error now

[GCHQDeveloper314]

Java 8 is required for Gaffer 1.22 versions. If you need to use Java 11 then checkout the v2-alpha branch and use that instead of the default develop branch. The v2-alpha branch is where we are doing development for Gaffer 2.0 and it supports Java 11.

[ibrijesh]

I have succefully build project dependencies using command in mvn clean install -Pquick but changes in code failing mvn checkstyle:check . What rules i have to follow while making changes ?

[GCHQDeveloper314]

When running the checks a list of checkstyle rule failures will be shown for each module which is failing. These are not summarised at the end, so you'll need to scroll up in order to see them. It may be easier to run the checks on the individual modules you've modified by using the -pl :module-name flag (e.g. -pl :store). You could also open a draft PR which will show us any checkstyle issues as part of our GitHub actions checks.