Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable GetAllElements Limit to tinkerpop #2989

Closed
t92549 opened this issue Jun 28, 2023 · 0 comments · Fixed by #3188
Closed

Add configurable GetAllElements Limit to tinkerpop #2989

t92549 opened this issue Jun 28, 2023 · 0 comments · Fixed by #3188
Assignees
@p29876
Labels
feature A proposed new feature tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.1

Comments

@t92549
Copy link
Contributor

t92549 commented Jun 28, 2023

Describe the new feature you'd like
There should be a configurable limit to the amount of elements returned in a GetAllElements by tinkerpop. This should use the Limit operation and be configurable. Perhaps it could use a TraversalStrategy

Why do you want this feature?
So gremlin users don't accidentally use GetAllElements and create a performance issue

Describe alternatives you've considered
If Gaffer had a property index, then a TraversalStrategy could be added to use that instead, as described in #277 (comment)
@t92549 t92549 added enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module labels Jun 28, 2023
@t92549 t92549 changed the title Add GetAllElements Limit to tinkerpop Add configurable GetAllElements Limit to tinkerpop Jun 28, 2023
@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone Jul 7, 2023
p29876 added a commit that referenced this issue Apr 5, 2024
@p29876
gh-2989 Add configurable GetAllElements limit to tinkerpop
156fc4b
p29876 added a commit that referenced this issue Apr 5, 2024
@p29876
gh-2989 Add configurable GetAllElements limit to tinkerpop
2a48c4c
@github-actions github-actions bot mentioned this issue Apr 9, 2024
Merged
tb06904 added a commit that referenced this issue Apr 9, 2024
@tb06904
Merge branch 'develop' into gh-2989-tinkerpop-getallelements-limit
a32849f
p29876 added a commit that referenced this issue Apr 30, 2024
@p29876
Merge branch 'develop' into gh-2989-tinkerpop-getallelements-limit
277a7cb
GCHQDeveloper314 pushed a commit that referenced this issue May 1, 2024
@p29876
Gh-2989: Add configurable GetAllElements Limit to Tinkerpop (#3188)
c0b950f 
* Add configurable GetAllElements limit to tinkerpop

* apply GetAllElements limit to edges

* move limit config from op_options to seperate property

* add tests for missing limit

* Set default limit
@GCHQDeveloper314 GCHQDeveloper314 modified the milestones: Backlog, v2.2.1 May 1, 2024
@tb06904 tb06904 added feature A proposed new feature and removed enhancement Improvement to existing functionality/feature labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p29876 p29876

Labels
feature A proposed new feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging a pull request may close this issue.

Gh-2989: Add configurable GetAllElements Limit to Tinkerpop gchq/Gaffer
4 participants
@t92549 @GCHQDeveloper314 @tb06904 @p29876