Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results should still be returned if JobTracker errors #3095

Closed
t92549 opened this issue Nov 15, 2023 · 0 comments · Fixed by #3146
Closed

Results should still be returned if JobTracker errors #3095

t92549 opened this issue Nov 15, 2023 · 0 comments · Fixed by #3146
Assignees
@l46978
Labels
enhancement Improvement to existing functionality/feature
Milestone
v2.2.0

Comments

@t92549
Copy link
Contributor

t92549 commented Nov 15, 2023

Describe the new feature you'd like
If the job tracker is enabled but the upload to it fails, the results from a Gaffer query will also fail and not be returned. This should not be the case, instead an error should be logged and the results still returned.

Why do you want this feature?
If a JobTracker fails, users still want results.

Describe alternatives you've considered
This fail or log could be set via a config option.
@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Nov 15, 2023
@l46978 l46978 linked a pull request Jan 16, 2024 that will close this issue
Gh-3095: Log JobTracker errors and still return results #3146
Merged
@github-actions github-actions bot mentioned this issue Jan 16, 2024
Merged
l46978 added a commit that referenced this issue Jan 19, 2024
@l46978
Merge remote-tracking branch 'origin/develop' into gh-3095-results-sh…
2299d2f 
…ould-still-be-returned-if-jobtracker-errors
GCHQDeveloper314 pushed a commit that referenced this issue Jan 24, 2024
@l46978
Gh-3095: Log JobTracker errors and still return results (#3146)
a1ea543
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.2.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l46978 l46978

Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Gh-3095: Log JobTracker errors and still return results gchq/Gaffer
3 participants
@t92549 @GCHQDeveloper314 @l46978