You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There are tests in Gaffer where an assertion is made that a results Edge is the same as an expected Edge, and the matchedVertex has an expected result, e.g.:
Describe the bug
There are tests in Gaffer where an assertion is made that a results Edge is the same as an expected Edge, and the
matchedVertex
has an expected result, e.g.:Gaffer/integration-test/src/test/java/uk/gov/gchq/gaffer/integration/impl/GeneratorsIT.java
Lines 104 to 110 in 1ef3621
However, they are just relying on the
Edge.equals
method which explicitly ignoresmatchedVertex
:Gaffer/core/data/src/main/java/uk/gov/gchq/gaffer/data/element/Edge.java
Lines 322 to 329 in 1ef3621
These tests should be fixed to properly check
matchedVertex
is as expected, e.g.:Gaffer/core/data/src/test/java/uk/gov/gchq/gaffer/data/element/EdgeTest.java
Line 72 in 1ef3621
Or, perhaps a custom condition should be made, similar to:
Gaffer/store-implementation/accumulo-store/src/test/java/uk/gov/gchq/gaffer/accumulostore/integration/AccumuloMatchedVertexIT.java
Lines 87 to 88 in 1ef3621
The text was updated successfully, but these errors were encountered: