Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FederatedStore While Operation Looping Bug #3166

Closed
GCHQDev404 opened this issue Mar 5, 2024 · 0 comments · Fixed by #3167
Closed

FederatedStore While Operation Looping Bug #3166

GCHQDev404 opened this issue Mar 5, 2024 · 0 comments · Fixed by #3167
Assignees
@GCHQDev404
Labels
bug Confirmed or suspected bug
Milestone
v2.2.2

Comments

@GCHQDev404
Copy link
Contributor

GCHQDev404 commented Mar 5, 2024 •
edited
Loading

Describe the bug
A While operation performed on the FederatedStore incorrectly triggers an infinite looping exception.

To Reproduce
Perform an operation chain within the While or Join. The operation chain chain should contain a operation which is not overridden with using a FederatedStore specific Handler.

Expected behaviour
While loops and joins of the operations should not trigger an "federated infinite looping" exception.
@GCHQDev404 GCHQDev404 added the bug Confirmed or suspected bug label Mar 5, 2024
@GCHQDev404 GCHQDev404 self-assigned this Mar 5, 2024
@GCHQDev404 GCHQDev404 changed the title FederatedStore While Looping Bug FederatedStore While Operation Looping Bug Mar 5, 2024
GCHQDev404 added a commit that referenced this issue Mar 5, 2024
@GCHQDev404
gh-3166 test to replicate issue.
87fb2fb
GCHQDev404 added a commit that referenced this issue Mar 5, 2024
@GCHQDev404
gh-3166 added test to replicate issue
61943dc
GCHQDev404 added a commit that referenced this issue Mar 5, 2024
@GCHQDev404
gh-3166 Make options field distinct in the While Looping logic
eb056e2
@github-actions github-actions bot mentioned this issue Mar 5, 2024
Merged
GCHQDev404 added a commit that referenced this issue Mar 5, 2024
@GCHQDev404
gh-3166 spotless
47a9145
GCHQDev404 added a commit that referenced this issue Mar 12, 2024
@GCHQDev404
gh-3166 setting up the test to replicate the issue with json.
c8a6197
GCHQDev404 added a commit that referenced this issue Mar 12, 2024
@GCHQDev404
gh-3166 ShallowCloneWithDeepOptions so options is not preserved in a …
f5d4b98 
…join or while loop. Other information should be retained.
GCHQDev404 added a commit that referenced this issue Mar 12, 2024
@GCHQDev404
gh-3166 temp removing the usage of new Join and while for testing
6883d4f
GCHQDev404 added a commit that referenced this issue Mar 12, 2024
@GCHQDev404
Merge branch 'develop' into gh-3166-FederatedStore-while-operation-lo…
0e819c6 
…oping-bug
GCHQDev404 added a commit that referenced this issue Mar 13, 2024
@GCHQDev404
gh-3166 json added to try replicate bug
c2d9821
GCHQDev404 added a commit that referenced this issue Mar 14, 2024
@GCHQDev404
gh-3166 json added to try replicate bug
d05b17f
GCHQDev404 added a commit that referenced this issue Mar 14, 2024
@GCHQDev404
gh-3166 tests
710dd7b
@github-actions github-actions bot mentioned this issue Mar 14, 2024
Closed
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.3.0 milestone Mar 15, 2024
GCHQDev404 added a commit that referenced this issue Mar 22, 2024
@GCHQDev404
Merge remote-tracking branch 'origin/gh-3166-FederatedStore-while-ope…
de93015 
…ration-looping-bug' into gh-3166-FederatedStore-while-operation-looping-bug
GCHQDev404 added a commit that referenced this issue Mar 22, 2024
@GCHQDev404
Merge branch 'develop' into gh-3166-FederatedStore-while-operation-lo…
f3e7b4e 
…oping-bug
GCHQDev404 added a commit that referenced this issue Apr 11, 2024
@GCHQDev404
Merge branch 'develop' into gh-3166-FederatedStore-while-operation-lo…
4afa0ae 
…oping-bug
GCHQDeveloper314 added a commit that referenced this issue Jun 3, 2024
@GCHQDeveloper314
Merge branch 'develop' into gh-3166-FederatedStore-while-operation-lo…
83d2df9 
…oping-bug
GCHQDeveloper314 added a commit that referenced this issue Jun 7, 2024
@GCHQDeveloper314
Merge branch 'develop' into gh-3166-FederatedStore-while-operation-lo…
c2374a0 
…oping-bug
GCHQDeveloper314 added a commit that referenced this issue Jun 7, 2024
@GCHQDev404 @GCHQDeveloper314
Gh-3166: FederatedStore While Operation Looping Bug (#3167)
cb343aa 
* gh-3166 test to replicate issue.

* gh-3166 added test to replicate issue

* gh-3166 Make options field distinct in the While Looping logic

* gh-3166 spotless

* gh-3166 setting up the test to replicate the issue with json.

* gh-3166 ShallowCloneWithDeepOptions so options is not preserved in a join or while loop. Other information should be retained.

* gh-3166 temp removing the usage of new Join and while for testing

* gh-3166 json added to try replicate bug

* gh-3166 json added to try replicate bug

* Update JoinHandler.java

* Test show log.

* changes get rid of logs error.

* Test changes to detect successful looping.

* test  tidy up

* Tidy up.

* rename

* copyright

* simplified the test

* import order

* Apply suggestions from code review

Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>

* Make use of Util method
Adding the FederatedStoreTestUtil.getFederatedStorePropertiesWithHashMapCache method instead of manually configuring Cache object

---------

Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDev404 GCHQDev404

Labels
bug Confirmed or suspected bug
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Gh-3166: FederatedStore While Operation Looping Bug gchq/Gaffer
2 participants
@GCHQDev404 @GCHQDeveloper314