Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gafferpop includes library specific classes in operation chains #3183

Closed
tb06904 opened this issue Mar 28, 2024 · 0 comments · Fixed by #3184
Closed

Gafferpop includes library specific classes in operation chains #3183

tb06904 opened this issue Mar 28, 2024 · 0 comments · Fixed by #3184
Assignees
@tb06904
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.1

Comments

@tb06904
Copy link
Member

tb06904 commented Mar 28, 2024

Describe the bug
This is relevant when using a proxy store to connect gafferpop to an existing a graph, the gremlin functions will fail. This is due to a slight implementation oversight where the gafferpop element generators are included in the operation chains that are used. This is an issue when using the proxy store as the whole chain is sent to the remote graph which may not have tinkerpop library and serialisation is currently missing.

Expected behaviour
A better solution would be to have this element translation happen locally instead. Essentially only the 'plain' Gaffer operations should be executed on the graph via gafferpop, all gafferpop specific bits should happen before or on the results outside of the chain sent to the remote graph.
@tb06904 tb06904 added the bug Confirmed or suspected bug label Mar 28, 2024
@tb06904 tb06904 added this to the v2.3.0 milestone Mar 28, 2024
@tb06904 tb06904 self-assigned this Mar 28, 2024
@tb06904 tb06904 linked a pull request Apr 2, 2024 that will close this issue
Gh-3183 Remove gafferpop specifics from operation chains #3184
Merged
@github-actions github-actions bot mentioned this issue Apr 2, 2024
Merged
GCHQDeveloper314 added a commit that referenced this issue Apr 3, 2024
@GCHQDeveloper314
Merge branch 'develop' into gh-3183-gafferpop-specifics-in-chains
2d8c079
@tb06904 tb06904 modified the milestones: v2.3.0, v2.2.1 Apr 4, 2024
@tb06904 tb06904 added the tinkerpop Specific to/touches the tinkerpop module label Apr 5, 2024
GCHQDeveloper314 pushed a commit that referenced this issue Apr 5, 2024
@tb06904
Gh-3183 Remove Gafferpop specifics from operation chains (#3184)
b294275 
* Make element generation happen outside of operation chain

* stop view filtering out all vertexes

* fix edge seeding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tb06904 tb06904

Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging a pull request may close this issue.

Gh-3183 Remove gafferpop specifics from operation chains gchq/Gaffer
1 participant
@tb06904