Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions Javadoc Java versions inconsistent #3196

Closed
GCHQDeveloper314 opened this issue Apr 22, 2024 · 0 comments · Fixed by #3197
Closed

Actions Javadoc Java versions inconsistent #3196

GCHQDeveloper314 opened this issue Apr 22, 2024 · 0 comments · Fixed by #3197
Assignees
@GCHQDeveloper314
Labels
automation GitHub Actions, CI/CD bug Confirmed or suspected bug
Milestone
v2.2.1

Comments

@GCHQDeveloper314
Copy link
Member

Describe the bug
The version of Java used for generating Javadoc in the continuous-integration.yaml workflow is not the same as the version used in the release.yml workflow.

Gaffer/.github/workflows/continuous-integration.yaml

Line 51 in 11ce18b

java-version: '8'

Gaffer/.github/workflows/release.yaml

Line 153 in 11ce18b

java-version: '11'

Both should be Java 11, otherwise incompatible Javadoc could be introduced which would cause an unexpected failure on release.
@GCHQDeveloper314 GCHQDeveloper314 added bug Confirmed or suspected bug automation GitHub Actions, CI/CD labels Apr 22, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.2.1 milestone Apr 22, 2024
@GCHQDeveloper314 GCHQDeveloper314 self-assigned this Apr 22, 2024
@github-actions github-actions bot mentioned this issue Apr 22, 2024
Merged
GCHQDeveloper314 added a commit that referenced this issue Apr 22, 2024
@GCHQDeveloper314
Gh-3196: Actions Javadoc Java versions inconsistent (#3197)
b0b9a1e 
Update Javadoc Java version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
automation GitHub Actions, CI/CD bug Confirmed or suspected bug
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging a pull request may close this issue.

Gh-3196: Actions Javadoc Java versions inconsistent gchq/Gaffer
1 participant
@GCHQDeveloper314