Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-2711: conditionally run tests on windows #2716

Merged
merged 6 commits into from
Jul 25, 2022
Merged

Gh-2711: conditionally run tests on windows #2716

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
459a17e
Added instructions so the tests will run conditionally on windows as …
lb324567 Jul 22, 2022
b0df840
undoing some accidental changes
lb324567 Jul 22, 2022
dd6a883
changing keywords
lb324567 Jul 22, 2022
f96aa22
adding 'bad' keywords to prove it works in PR
lb324567 Jul 22, 2022
7398b99
putting correct keywords back so they go into the PR
lb324567 Jul 22, 2022
d78b917
changing release so it is 'disabled' as a keyword. Added comment on w…
lb324567 Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/continuous-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,14 @@ jobs:
mvn -ntp javadoc:javadoc -Pquick

build:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: true
matrix:
# The below line does the following, check if the branch name contains the words 'windows' or 'release'.
# If these words are present it runs the tests on Windows AND Ubuntu. If the words aren't present it runs the tests on Ubuntu ONLY
# The 'release' keyword is currently disabled. Change 'release-disabled-for-now' to 'release' once the tests have been fixed to reenable this.
os: ${{ fromJSON( (contains( github.head_ref, 'windows') || contains( github.head_ref, 'release-disabled-for-now') ) && '["ubuntu-latest", "windows-latest"]' || '["ubuntu-latest"]' ) }}
modules:
- name: Core
values: :gaffer2,:core,:access,:cache,:common-util,:data,:exception,:graph,:operation,:serialisation,:store,:type
Expand Down