Gh-2868: ProxyStore Jersey dependency issues #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exclusions had no effect as the jersey package name had changed. The newer versions can't be excluded as they are required.
These versions are now managed across the whole project
No longer required as now managed across the whole project
Codecov Report
@@ Coverage Diff @@
## v2-alpha #2869 +/- ##
===========================================
Coverage ? 65.57%
Complexity ? 2304
===========================================
Files ? 623
Lines ? 19462
Branches ? 2271
===========================================
Hits ? 12762
Misses ? 5640
Partials ? 1060 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Appears to be required at runtime by ProxyStore
GCHQDev404
approved these changes
Jan 23, 2023
lb324567
approved these changes
Jan 23, 2023
t92549
approved these changes
Jan 23, 2023
GCHQDev404
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Remove outdated jersey exclusions and manage versions instead The exclusions had no effect as the jersey package name had changed. The newer versions can't be excluded as they are required. * Remove redundent version specification These versions are now managed across the whole project * Remove duplicate dependencyManagement No longer required as now managed across the whole project * Update Copyright headers * Move jersey-hk2 to also be a runtime dependency Appears to be required at runtime by ProxyStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue