Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v2-alpha from workflows #2939

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Remove v2-alpha from workflows #2939

merged 2 commits into from
Apr 25, 2023

Conversation

t92549
Copy link
Contributor

@t92549 t92549 commented Apr 18, 2023 •
edited by github-actions bot
Loading

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v2-alpha@719a307). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5fc97bf differs from pull request most recent head 3b2ddcb. Consider uploading reports for the commit 3b2ddcb to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             v2-alpha    #2939   +/-   ##
===========================================
  Coverage            ?   56.70%           
  Complexity          ?     2497           
===========================================
  Files               ?      919           
  Lines               ?    32402           
  Branches            ?     3294           
===========================================
  Hits                ?    18375           
  Misses              ?    12640           
  Partials            ?     1387

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@t92549
Copy link
Contributor Author

t92549 commented Apr 18, 2023

In draft as javadoc doesn't seem to be created in the correct place, @GCHQDeveloper314 thoughts?

@t92549 t92549 linked an issue Apr 19, 2023 that may be closed by this pull request
Remove v2-alpha from workflows #2938
Closed
GCHQDeveloper314
GCHQDeveloper314 reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for Javadoc to be added as an extra commit.

.github/workflows/continuous-integration.yaml Show resolved Hide resolved
@t92549 t92549 marked this pull request as ready for review April 25, 2023 11:40
GCHQDeveloper314
GCHQDeveloper314 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I have raised #2942 to correct the Javadco issue properly.

@t92549 t92549 merged commit 76ddd5f into v2-alpha Apr 25, 2023
@t92549 t92549 deleted the gh-2938-remove-alpha-workflows branch April 25, 2023 12:08
@t92549 t92549 mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove v2-alpha from workflows
3 participants
@t92549 @codecov-commenter @GCHQDeveloper314