Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-2972: Codecov can generate inconsistent coverage reports #2973

Conversation

GCHQDeveloper314
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 commented Jun 8, 2023

Compared to before this avoids making multiple uploads to codecov and allows the codecov upload to be reattempted with rerunning any tests.

Related Issue

Combared to before this avoids making multiple uploads to codecov and allows the codecov upload to be reattempted with rerunning any tests.
JaCoCo was disabled for these causing all reports to be missing
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #2973 (81502ca) into develop (0123e0a) will decrease coverage by 8.99%.
The diff coverage is n/a.

❗ Current head 81502ca differs from pull request most recent head 47ffd2b. Consider uploading reports for the commit 47ffd2b to get more accurate results

@@              Coverage Diff              @@
##             develop    #2973      +/-   ##
=============================================
- Coverage      65.25%   56.27%   -8.99%     
- Complexity      2314     2509     +195     
=============================================
  Files            717      926     +209     
  Lines          23133    32722    +9589     
  Branches        2673     3303     +630     
=============================================
+ Hits           15095    18413    +3318     
- Misses          6820    12903    +6083     
- Partials        1218     1406     +188     

see 211 files with indirect coverage changes

t92549
t92549 previously approved these changes Jun 9, 2023
@GCHQDeveloper314
Copy link
Member Author

Branch name is wrong. This needs to be reopened as the branch cannot be renamed in-situ.

@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-2971-Codecov-can-generate-inconsistent–coverage-reports branch June 9, 2023 09:48
@GCHQDeveloper314 GCHQDeveloper314 restored the gh-2971-Codecov-can-generate-inconsistent–coverage-reports branch June 9, 2023 10:00
@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-2971-Codecov-can-generate-inconsistent–coverage-reports branch June 9, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Spring version
2 participants