-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-2997: Prevented a NullPointerException being thrown. #2998
Conversation
… NullPointerException, set the zooKeeperPort to the zooKeeper default port.
...ntation/accumulo-store/src/test/java/uk/gov/gchq/gaffer/accumulostore/MiniAccumuloStore.java
Outdated
Show resolved
Hide resolved
…T_ZOOKEEPER_PORT) call occurs only once.
c76df46
to
02d02b5
Compare
@GCHQDeveloper314 |
I believe they were cancelled because of force pushing to the branch. Please avoid force pushing, as we squash all commits on merge there's no need to force push. It can cause issues with the CI sometimes. There's a need to update the copyright header on the file that was changed to include the current year. |
@GCHQDeveloper314 |
Codecov Report
@@ Coverage Diff @@
## develop #2998 +/- ##
=============================================
- Coverage 65.17% 65.16% -0.02%
+ Complexity 2633 2631 -2
=============================================
Files 901 901
Lines 28797 28797
Branches 3238 3238
=============================================
- Hits 18769 18765 -4
- Misses 8572 8574 +2
- Partials 1456 1458 +2 |
...ntation/accumulo-store/src/test/java/uk/gov/gchq/gaffer/accumulostore/MiniAccumuloStore.java
Outdated
Show resolved
Hide resolved
Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
@GCHQDeveloper314 copyright has been updated. |
This commit refactors the code to address the scenario where the zookeepers property is null. The modified code now checks if the zookeepers property is null, and if so, it sets the ZooKeeperPort to the default value. This change ensures that a NullPointerException is avoided when accessing the zookeepers property and provides a more robust behavior in the case of a missing or null value.