Gh-3209: GetAll Limit fails on Proxy Store #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3214 +/- ##
==========================================
Coverage 66.86% 66.87%
- Complexity 2557 2558 +1
==========================================
Files 912 912
Lines 29276 29287 +11
Branches 3265 3266 +1
==========================================
+ Hits 19576 19586 +10
Misses 8256 8256
- Partials 1444 1445 +1 ☔ View full report in Codecov by Sentry. |
core/operation/src/main/java/uk/gov/gchq/gaffer/operation/OperationChain.java
Show resolved
Hide resolved
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
...va/uk/gov/gchq/gaffer/proxystore/response/deserialiser/impl/DefaultResponseDeserialiser.java
Show resolved
Hide resolved
p29876
reviewed
May 16, 2024
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Show resolved
Hide resolved
GCHQDeveloper314
approved these changes
May 20, 2024
p29876
approved these changes
May 21, 2024
GCHQDev404
suggested changes
May 22, 2024
...va/uk/gov/gchq/gaffer/proxystore/response/deserialiser/impl/DefaultResponseDeserialiser.java
Show resolved
Hide resolved
GCHQDev404
reviewed
May 22, 2024
core/operation/src/main/java/uk/gov/gchq/gaffer/operation/OperationChain.java
Show resolved
Hide resolved
GCHQDev404
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of the issues in the original issue, two minor fixes:
GafferPopGraphStepnulloperation chain options.Added work around to main serialisation error in the proxy store so that it attempts to deserialise element iterators. This will be fixed in a larger rework of the proxy store so that it does not need to double deserialise.
Related issue