Gh-3219: Fix inV() and outV() missing results #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3221 +/- ##
=============================================
+ Coverage 66.86% 66.88% +0.01%
+ Complexity 2557 2556 -1
=============================================
Files 912 912
Lines 29287 29303 +16
Branches 3266 3267 +1
=============================================
+ Hits 19583 19598 +15
Misses 8258 8258
- Partials 1446 1447 +1 ☔ View full report in Codecov by Sentry. |
p29876
reviewed
May 23, 2024
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopEdge.java
Outdated
Show resolved
Hide resolved
tb06904
reviewed
May 23, 2024
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopEdge.java
Show resolved
Hide resolved
p29876
approved these changes
May 24, 2024
tb06904
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a fix which will use an Operation Chain to search the graph for the vertex by ID to get the right results. Fixes 32 cucumber tests.
Related issue