Gh-3237 Implement DeleteElements for Map Store #3239

p29876 · 2024-06-13T12:53:03Z

Related issue

Resolve Implement target delete for Map Store #3237

core/operation/src/main/java/uk/gov/gchq/gaffer/operation/impl/delete/DeleteElements.java

codecov · 2024-06-13T14:20:37Z

Codecov Report

Attention: Patch coverage is 80.31496% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.14%. Comparing base (b103962) to head (1fed27b).

Files	Patch %	Lines
...q/gaffer/operation/impl/delete/DeleteElements.java	76.08%	11 Missing ⚠️
.../uk/gov/gchq/gaffer/commonutil/stream/Streams.java	0.00%	8 Missing ⚠️
...hq/gaffer/mapstore/impl/DeleteElementsHandler.java	91.22%	0 Missing and 5 partials ⚠️
...java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #3239      +/-   ##
=============================================
+ Coverage      67.07%   67.14%   +0.07%     
- Complexity      2558     2569      +11     
=============================================
  Files            919      921       +2     
  Lines          29483    29610     +127     
  Branches        3289     3297       +8     
=============================================
+ Hits           19775    19883     +108     
- Misses          8261     8277      +16     
- Partials        1447     1450       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/operation/src/main/java/uk/gov/gchq/gaffer/operation/impl/delete/DeleteElements.java

...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java

tb06904 · 2024-06-25T10:46:43Z

Quality Gate failed

Failed conditions 3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

I think the duplication is largely due to a wider issue where many of the core classes used here are interfaces which expect class instance variables in the implementing classes. This results in all implementing classes creating the same variables and method overrides, one way to fix this would be to use abstract classes where appropriate instead but it is a larger problem to fix.

...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java

...lementation/accumulo-store/src/main/java/uk/gov/gchq/gaffer/accumulostore/AccumuloStore.java

...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java

store-implementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/MapImpl.java

core/common-util/src/main/java/uk/gov/gchq/gaffer/commonutil/stream/Streams.java

sonarcloud · 2024-07-10T09:27:20Z

Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

* prepare for next development iteration * prepare for next development iteration * prepare for next development iteration * Gh-3244 fix ci versioning (#3245) * move to revision property * update ci * update ignore * Gh-3085 Fix payloadOperation being exposed by getOperations (#3247) * Gh-3085 Fix payloadOperation being exposed by getOperations * headers * add test * Gh-3220: Standardise GafferPop Tests (#3243) * update graph IT tests * Rename GraphIT -> GraphTest * create graph IT * Create Modern Federated example graph run graph tests on multiple graph types * Update federated IT tests move non-federates specific tests to graph tests * tidying * remove public + spotless * sonarcloud * sonarcloud * Use allEdges/allEntities * tidy --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3237 Implement DeleteElements for Map Store (#3239) * Gh-3237 Implement DeleteElements for Map Store * remove unused param * spotless * codecov and sonarcloud * improve codecov and sonarcloud * reduce test duplication and add to federated store * checkstyle * remove unused properties and improve check * address PR comments and improve tests * fix indent * checkstyle * copyright * bump version * address comments * add comment --------- Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> Co-authored-by: tb06904 <141412860+tb06904@users.noreply.github.com> * Gh-3238: target delete accumulo (#3249) * Gh-3237 Implement DeleteElements for Map Store * remove unused param * spotless * wip * finish * checkstyle * codecov and sonarcloud * improve codecov and sonarcloud * reduce test duplication and add to federated store * checkstyle * remove unused properties and improve check * Gh-3238 Implement DeleteElements for Accumulo * add accumulo test to federated store * remove commented test * address comments * address comments * checkstyle * checkstyle * headers * code cov * remove public * remove AccumuloClient * code cov * checkystle * add test --------- Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> * Gh-3246: Add an explain step and GafferPop to REST API (#3248) * basic rest controller for gremlin * basic websocket endpoint for gremlin inside the rest api * improvements to the gremlin ws endpoint * basic hooks for storing last chain * Add working explain endpoint and tidy websocket * Add open telementry reporting * overhaul gremlin user auth and move cypher translator * basic testing for gremlin controller * move to utils class * basic testing updates * update the options parsing and testing * test tweaks * updates from testing * tweaks * spotless * address comments --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3250: GetElementsWithinSet bug fix (#3251) * initial testing and changes * tidy up, remove bug test and copyright headers * fix commented out lines * additional federated tests * reduce duplicate tests * checkstyle * add inOutType * copyright * fix version variable * address comments --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3253 Fix custom types in gremlin (#3255) * add conversions so gafferpop edges and vertexes are graphson compliant * update testing * update testing * javadoc * make sure cypher types can be used correctly * typo * Gh-3259: Improve release process (#3260) * update release pipelines * simplify * release notes fix * remove comment * address comments * Make gremlin config message clearer (#3264) * Gh-3258: Sonarcloud Issues (#3261) * initial improvements * more test tidy up * more fixes * improve coverage * copyright * fix DeleteAllData test * checkstyle * address comments * address comments * checkstyle * checkstyle --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3254: Standardise Spring REST user authentication (#3263) * remove unnecessary controller interfaces and add http header setting * test tweaks * Update rest-api/spring-rest/src/main/java/uk/gov/gchq/gaffer/rest/controller/JobController.java Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> --------- Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * prepare release gaffer2-2.3.0 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: tb06904 <141412860+tb06904@users.noreply.github.com> Co-authored-by: p29876 <165825455+p29876@users.noreply.github.com> Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com>

Gh-3237 Implement DeleteElements for Map Store

803cd8b

p29876 commented Jun 13, 2024

View reviewed changes

core/operation/src/main/java/uk/gov/gchq/gaffer/operation/impl/delete/DeleteElements.java Outdated Show resolved Hide resolved

p29876 added 2 commits June 13, 2024 13:30

remove unused param

ab9e97e

spotless

0c01c89

cn337131 added 4 commits June 14, 2024 09:58

codecov and sonarcloud

01181d0

improve codecov and sonarcloud

7aa251e

reduce test duplication and add to federated store

0576a6e

checkstyle

ad4928f

cn337131 marked this pull request as ready for review June 18, 2024 12:28

remove unused properties and improve check

ea8dcf1

tb06904 reviewed Jun 18, 2024

View reviewed changes

cn337131 and others added 7 commits June 19, 2024 10:22

address PR comments and improve tests

91a2652

fix indent

73b9908

checkstyle

a5c6890

copyright

041f8f3

Merge branch 'develop' into gh-3237-target-delete-map-store

f73b952

Merge branch 'develop' into gh-3237-target-delete-map-store

aff204c

bump version

9c19be6

rj77259 reviewed Jun 28, 2024

View reviewed changes

cn337131 added 2 commits June 28, 2024 10:28

address comments

ad46edc

Merge branch 'develop' into gh-3237-target-delete-map-store

7790adf

tb06904 previously approved these changes Jul 1, 2024

View reviewed changes

add comment

39fbfe9

cn337131 dismissed tb06904’s stale review via 39fbfe9 July 3, 2024 08:20

GCHQDeveloper314 reviewed Jul 3, 2024

View reviewed changes

core/common-util/src/main/java/uk/gov/gchq/gaffer/commonutil/stream/Streams.java Show resolved Hide resolved

tb06904 approved these changes Jul 10, 2024

View reviewed changes

Merge branch 'develop' into gh-3237-target-delete-map-store

1fed27b

rj77259 approved these changes Jul 10, 2024

View reviewed changes

wb36499 merged commit cda4cdd into develop Jul 10, 2024
27 of 28 checks passed

wb36499 deleted the gh-3237-target-delete-map-store branch July 10, 2024 14:29

cn337131 added the feature A proposed new feature label Aug 1, 2024

cn337131 added this to the v2.3.0 milestone Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gh-3237 Implement DeleteElements for Map Store #3239

Gh-3237 Implement DeleteElements for Map Store #3239

p29876 commented Jun 13, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jun 13, 2024 •

edited

Loading

tb06904 commented Jun 25, 2024 •

edited

Loading

Quality Gate failed

sonarcloud bot commented Jul 10, 2024

Gh-3237 Implement DeleteElements for Map Store #3239

Gh-3237 Implement DeleteElements for Map Store #3239

Conversation

p29876 commented Jun 13, 2024 • edited by github-actions bot Loading

Related issue

codecov bot commented Jun 13, 2024 • edited Loading

Codecov Report

tb06904 commented Jun 25, 2024 • edited Loading

Quality Gate failed

sonarcloud bot commented Jul 10, 2024

Quality Gate failed

p29876 commented Jun 13, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jun 13, 2024 •

edited

Loading

tb06904 commented Jun 25, 2024 •

edited

Loading