-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3300: Graph access controls for federated POC #3307
Conversation
…trol-federated-poc
…trol-federated-poc
…trol-federated-poc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3307 +/- ##
=============================================
+ Coverage 67.87% 67.91% +0.04%
Complexity 2596 2596
=============================================
Files 951 952 +1
Lines 30377 30469 +92
Branches 3347 3361 +14
=============================================
+ Hits 20617 20692 +75
- Misses 8293 8305 +12
- Partials 1467 1472 +5 ☔ View full report in Codecov by Sentry. |
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java
Show resolved
Hide resolved
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java
Show resolved
Hide resolved
…trol-federated-poc
Quality Gate passedIssues Measures |
Adds optional access controls for graphs added to federated stores to prevent users having visibility or modifying graphs they don't have access to.
Follows a similar concept to the old federated store by using the existing
AccessControlledResource
class and associated framework already in place. One main difference isgraphAuths
no longer exist they can instead be defined inside theDefaultUserPredicate
or custom predicate, this would look something like the following if done via JSON:Related issue