Gh-3315: Add AbstractStoreITs to the new fed store POC #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cn337131
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3316 +/- ##
=============================================
+ Coverage 67.94% 67.98% +0.04%
Complexity 2596 2596
=============================================
Files 955 955
Lines 30530 30531 +1
Branches 3369 3371 +2
=============================================
+ Hits 20744 20757 +13
+ Misses 8306 8299 -7
+ Partials 1480 1475 -5 ☔ View full report in Codecov by Sentry. |
cn337131
commented
Oct 15, 2024
...d-store/src/test/java/uk/gov/gchq/gaffer/federated/simple/integration/FederatedStoreITs.java
Outdated
Show resolved
Hide resolved
p29876
previously approved these changes
Oct 18, 2024
….com:gchq/Gaffer into gh-3315-add-abstract-store-ITs-to-simple-fed
|
p29876
approved these changes
Oct 30, 2024
tb06904
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the AbstractStoreITs to the new federated store POC, there are a few tests that still fail and have been set to skip but the vast majority pass.
Tickets will be raised to look into the issues that have been highlighted by these tests.
Related issue