Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-3350: Optimisations for federated POC #3357

Closed
wants to merge 18 commits into from
Closed

Gh-3350: Optimisations for federated POC #3357

wants to merge 18 commits into from

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Jan 21, 2025 •
edited by github-actions bot
Loading

Some minor optimisations and helpful functions for new federated store, changes include:

  • Minimising stream API on small collections to save initialisation overhead.
  • Using array/list data types where iteration performance is more important.
  • Helpful operation to allow changing default graph IDs.
  • Some tweaks hit the cache fewer times.
  • Better shortcut logic on checks.

Related issue

@tb06904 tb06904 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Jan 21, 2025
@tb06904 tb06904 added this to the 2.4.0 milestone Jan 21, 2025
@tb06904 tb06904 requested review from cn337131 and p29876 January 21, 2025 11:13
@tb06904 tb06904 linked an issue Jan 21, 2025 that may be closed by this pull request
Investigate optimisations for federated POC #3350
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@p29876 p29876 mentioned this pull request Jan 27, 2025
Open
@p29876
Copy link
Member

p29876 commented Jan 27, 2025

Going to close this PR and split up the changes so we can progress
Some of the fixes are in #3358
The optimisations are to follow

@p29876 p29876 closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cn337131 cn337131 Awaiting requested review from cn337131

@p29876 p29876 Awaiting requested review from p29876

Assignees
No one assigned
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Investigate optimisations for federated POC
2 participants
@tb06904 @p29876