Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HqdmObjectFactory NullPointerException #102

Closed
twalmsley opened this issue Jan 16, 2023 · 1 comment
Closed

HqdmObjectFactory NullPointerException #102

twalmsley opened this issue Jan 16, 2023 · 1 comment
Assignees
@twalmsley
Labels
bug Something isn't working

Comments

@twalmsley
Copy link
Collaborator

HqdmObjectFactory throws NPE when a dynamic entity is requested with the same interface specified more than once.
This is because the DynamicObjects class swallows an exception and returns null when it should probably propagate the exception to the callers so that the root cause isn't hidden.
@twalmsley twalmsley added the bug Something isn't working label Jan 16, 2023
@twalmsley twalmsley self-assigned this Jan 16, 2023
@twalmsley
Copy link
Collaborator Author

Just to clarify: This change is required because some of the canned queries in MC core can result in specifying the same rdf:type twice, but the Proxy creation interface requires them to be specified only once, hence the code change to use Set instead of LIst.

GCHQDeveloper42 pushed a commit that referenced this issue Jan 27, 2023
@twalmsley @GCHQDeveloper42
#102 Fix NPE in HqdmObjectFactory
765d710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twalmsley twalmsley

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

102-hqdmobjectfactory-nullpointerexception gchq/MagmaCore
1 participant
@twalmsley