Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MapReduce solver Indexing bug #779

Closed
qh681248 opened this issue Sep 19, 2024 · 1 comment · Fixed by #790
Closed

Fix MapReduce solver Indexing bug #779

qh681248 opened this issue Sep 19, 2024 · 1 comment · Fixed by #790
Assignees
Labels
bug Something isn't working

Comments

@qh681248
Copy link
Contributor

What's the problem?

Mapreduce does not compute indices correctly

If you add plt.show() and run examples/pounce_map_reduce.py, you will see that only the first 10 frames are being chosen from the 106 frames, this is because coreset.unweighted_indices is not working properly

The example worked as of commit d99d4e4 and ran faster

How can we reproduce the issue?

Run examples/pounce_map_reduce.py and either print the indices of the coreset generated by map reduce or add plt.show() at the end

Python version

3.12

Package version

0.2.1

Operating system

Windows

Other packages

No response

Relevant log output

No response

@qh681248 qh681248 added bug Something isn't working new Something yet to be discussed by development team labels Sep 19, 2024
@tp832944 tp832944 removed the new Something yet to be discussed by development team label Sep 19, 2024
qh681248 added a commit that referenced this issue Sep 24, 2024
… _jit_tree function to return indices as well, changed the reduce method to keep track of indices, added a line plt.show() to pounce.py
qh681248 added a commit that referenced this issue Sep 24, 2024
… _jit_tree function to return indices as well, changed the reduce method to keep track of indices, added a line plt.show() to pounce.py
qh681248 added a commit that referenced this issue Sep 25, 2024
…e method returns coreset with indices bigger than the leafsize as was present in #779. This test fails when that bug is present and passes when it is not present
@qh681248 qh681248 mentioned this issue Sep 25, 2024
9 tasks
@qh681248 qh681248 linked a pull request Sep 26, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@tp832944 @qh681248 and others