Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower bounds on dependencies #807

Closed
rg936672 opened this issue Oct 14, 2024 · 1 comment · Fixed by #920
Closed

Add lower bounds on dependencies #807

rg936672 opened this issue Oct 14, 2024 · 1 comment · Fixed by #920
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@rg936672
Copy link
Contributor

rg936672 commented Oct 14, 2024

What's the issue?

Currently, most of Coreax's dependencies don't have lower bounds specified, so aren't accurate - we clearly don't support very early versions of most of our dependencies. Add minimum versions for each, ideally as loose as possible. This can be tested with uv's --resolution lowest strategy. - see #918.

Since automated testing of this is a separate ticket, this ticket can be resolved by just adding naive "latest major version" bounds on the dependencies. (Just doing this puts us in a much better position than the majority of the Python ecosystem!)

@rg936672 rg936672 added the new Something yet to be discussed by development team label Oct 14, 2024
@tp832944 tp832944 added dependencies Pull requests that update a dependency file and removed new Something yet to be discussed by development team labels Oct 16, 2024
@pc532627

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants