Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower bound for all direct dependencies #920

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

rg936672
Copy link
Contributor

@rg936672 rg936672 commented Jan 7, 2025

PR Type

  • Bugfix
  • Refactoring (no functional changes)

Description

Add lower bounds for all direct dependencies. These are largely just "whatever the most recent major version was", or most recent minor version for 0ver dependencies. Closes #807.

How Has This Been Tested?

Existing tests pass as expected. This doesn't change which dependencies are installed when solving for the latest dependencies, but should prevent solvers from erroneously backtracking to early versions of our dependencies.

We don't actually test with our stated lower bounds - that's left for #918.

Does this PR introduce a breaking change?

No.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

Updated anyio v4.7.0 -> v4.8.0
Updated pygments v2.18.0 -> v2.19.1
Updated ruamel-yaml v0.18.8 -> v0.18.10
Updated setuptools v75.6.0 -> v75.7.0
Updated trove-classifiers v2024.10.21.16 -> v2025.1.6.15
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Performance review

Commit 591e063 - Merge 8a1a40f into 4cb97fb

No significant changes to performance.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Performance review

Commit e7d193c - Merge 5e1d449 into 4cb97fb

No significant changes to performance.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Performance review

Commit 8938a8e - Merge c36b184 into 4cb97fb

No significant changes to performance.

@tp832944 tp832944 self-requested a review January 10, 2025 09:42
@tp832944 tp832944 merged commit fde187f into main Jan 10, 2025
19 checks passed
@tp832944 tp832944 deleted the feature/lower-bound-deps branch January 10, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lower bounds on dependencies
2 participants