Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative weights #698

Merged
merged 6 commits into from
Jul 15, 2024
Merged

fix negative weights #698

merged 6 commits into from
Jul 15, 2024

Conversation

db091756
Copy link
Member

@db091756 db091756 commented Jul 10, 2024

PR Type

  • Bugfix

Description

Ensures weights are greater than or equal to zero and sum to one. Fixes bug detailed in listed issue.

How Has This Been Tested?

All tests pass.

Does this PR introduce a breaking change?

(Write your answer here.)

Screenshots

(Write your answer here.)

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@db091756 db091756 linked an issue Jul 10, 2024 that may be closed by this pull request
1 task
@db091756 db091756 changed the title feat: ensure conditions of solution are met fix negative weights Jul 10, 2024
Copy link
Contributor

@pc532627 pc532627 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small unittest request but otherwise looks good.

coreax/util.py Outdated Show resolved Hide resolved
@pc532627 pc532627 self-requested a review July 15, 2024 13:09
@pc532627 pc532627 merged commit b964d8b into main Jul 15, 2024
21 of 22 checks passed
@pc532627 pc532627 deleted the bug/negative-weights branch July 15, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: negative weights
2 participants