Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/more kernels v2 electric boogaloo #742

Merged
merged 11 commits into from
Aug 23, 2024

Conversation

db091756
Copy link
Member

@db091756 db091756 commented Aug 21, 2024

PR Type

  • Feature
  • Tests

Description

Add Poisson kernel *see Table 3.1 (https://arxiv.org/pdf/1605.09522)). Add Matérn kernel (see https://en.wikipedia.org/wiki/Mat%C3%A9rn_covariance_function), with no explicit gradients.

How Has This Been Tested?

Added unit tests.

Does this PR introduce a breaking change?

(Write your answer here.)

Screenshots

(Write your answer here.)

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@db091756 db091756 linked an issue Aug 21, 2024 that may be closed by this pull request

This comment was marked as outdated.

@pc532627 pc532627 self-requested a review August 22, 2024 10:24

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

@pc532627 pc532627 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor change requests.

coreax/kernels/scalar_valued.py Show resolved Hide resolved
coreax/kernels/scalar_valued.py Outdated Show resolved Hide resolved
coreax/kernels/scalar_valued.py Show resolved Hide resolved
tests/unit/test_kernels.py Outdated Show resolved Hide resolved
tests/unit/test_kernels.py Outdated Show resolved Hide resolved
Copy link
Contributor

Performance review

Statistically significant changes

  • basic_herding:
    • OLD: compilation 0.4293 units ± 0.04071 units; execution 2.622 units ± 0.03397 units
    • NEW: compilation 0.3712 units ± 0.04129 units; execution 2.685 units ± 0.04446 units
    • Significant decrease in compilation time (-13.53%, p=0.005312)

Normalisation values for new data:
Compilation: 1 unit = 521.1 ms
Execution: 1 unit = 685.35 ms

Copy link
Contributor

Performance review

Statistically significant changes

  • basic_herding:
    • OLD: compilation 0.5149 units ± 0.04038 units; execution 2.586 units ± 0.02194 units
    • NEW: compilation 0.4194 units ± 0.0225 units; execution 2.571 units ± 0.01817 units
    • Significant decrease in compilation time (-18.56%, p=1.275e-05)

Normalisation values for new data:
Compilation: 1 unit = 533.71 ms
Execution: 1 unit = 683.07 ms

@db091756 db091756 requested a review from pc532627 August 23, 2024 07:46
@pc532627 pc532627 merged commit 1869fad into main Aug 23, 2024
23 checks passed
@pc532627 pc532627 deleted the feat/more-kernels-v2-electric-boogaloo branch August 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Matérn and Poisson Kernel
2 participants