Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add analytic kernel herding tests. #794

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

pc532627
Copy link
Contributor

@pc532627 pc532627 commented Oct 1, 2024

Refs: #786
Closes: #786

PR Type

  • Documentation content changes
  • Tests

Description

Kernel herding now has an analytical test (for the case where unique is set to true and when it is set to false) and these tests have been used to showcase to a user a minimal worked example in the documentation.

How Has This Been Tested?

Two new tests added and pass.

Does this PR introduce a breaking change?

N/A

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Performance review

Commit d5a9346 - Merge 5e9c46e into 41b3922

No significant changes to performance.

@pc532627 pc532627 requested a review from qh681248 October 4, 2024 08:52
@tp832944 tp832944 linked an issue Oct 4, 2024 that may be closed by this pull request
qh681248
qh681248 previously approved these changes Oct 4, 2024
tests/unit/test_solvers.py Show resolved Hide resolved
tests/unit/test_solvers.py Outdated Show resolved Hide resolved
tests/unit/test_solvers.py Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Performance review

Commit a08a504 - Merge 6d163e3 into ba4a3c1

No significant changes to performance.

tests/unit/test_solvers.py Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Performance review

Commit 084a53d - Merge 081d321 into ba4a3c1

No significant changes to performance.

@qh681248 qh681248 self-requested a review October 8, 2024 11:51
@qh681248 qh681248 merged commit c944ed6 into main Oct 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an analytic test for kernel herding
2 participants