Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv update, create benchmark dependency group #888

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

tp832944
Copy link
Contributor

@tp832944 tp832944 commented Dec 10, 2024

PR Type

  • Build related changes
  • CI related changes

Description

Create benchmark dependency group to include requirements for benchmarking. Note that some of these requirements are not needed until after #880 has been merged. setuptools should not be explicitly required. It can be re-added in future if the build breaks.

Switch to dependency-groups in pyproject.toml. uv's dev-dependencies will be deprecated at some point.

Other tidying in dependency list.

uv package update.

How Has This Been Tested?

Existing tests pass as expected.

Does this PR introduce a breaking change?

No, except if you have started developing in the main coreax package using torch, torchvision, umap-learn or llvmlite.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

uv's dev-dependencies will be deprecated at some point.
Copy link
Contributor

Performance review

Commit 156b424 - Merge 7663792 into f2a57a3

No significant changes to performance.

Copy link
Contributor

Performance review

Commit 2c50e0a - Merge 5b52ec6 into f2a57a3

No significant changes to performance.

@tp832944 tp832944 self-assigned this Dec 10, 2024
@tp832944 tp832944 changed the title uv update uv update, create benchmark dependency group Dec 10, 2024
Copy link
Contributor

Performance review

Commit beb010b - Merge 9c8ea2c into f2a57a3

No significant changes to performance.

Copy link
Contributor

Performance review

Commit 2d2194d - Merge e7436cb into f2a57a3

No significant changes to performance.

@bk958178 bk958178 requested a review from gw265981 December 11, 2024 09:45
Copy link
Contributor

@gw265981 gw265981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are in line with uv's dependency management guidelines.

@gw265981 gw265981 merged commit b3232f3 into main Dec 11, 2024
19 checks passed
@gw265981 gw265981 deleted the chore/update_uv branch December 11, 2024 11:30
@dotmain

This comment was marked as off-topic.

@dotmain

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants