-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
This was defaulting to a very old beta version
This PR is for compatibility with Gaffer 2 alpha 2. CI will fail until that version is used in Gaffer tools, this branch will then build. |
After alpha 2 is released, a PR to update the Gaffer version will be made into this branch. That will mean the CI can be tested. |
Codecov Report
@@ Coverage Diff @@
## v2-alpha #995 +/- ##
==============================================
+ Coverage 45.00% 45.15% +0.15%
Complexity 101 101
==============================================
Files 25 25
Lines 900 897 -3
Branches 74 73 -1
==============================================
Hits 405 405
+ Misses 465 462 -3
Partials 30 30
Continue to review full report at Codecov.
|
...rmance-testing-core/src/main/java/uk/gov/gchq/gaffer/performancetesting/query/QueryTest.java
Show resolved
Hide resolved
* Updated Gaffer version to 2.0.0-alpha-0.2 * Added new koryphe function to gafferpy Co-authored-by: Gaffer <github-actions@github.com>
Because of Gaffer #2634 tests which require WARs are failing. This will be fixed in the next alpha. |
7aa3db1
to
02ecdd9
Compare
This PR will need to be merged as is, unless we delay a release until alpha 3. The Gaffer WARs for alpha 2 are broken, they are used for these CI tests and so they will always fail. The WAR problem was fixed in Gaffer #2635. To test this branch, clone 2635 and build it, then clone this branch, change the gaffer versions to the SNAPSHOT version used by 2635 and then run the tests - they should all pass. @t92549 - could you take a look at testing and confirming this locally? |
Related Issue