Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for gafferpy helper functions #8

Open
t92549 opened this issue Aug 4, 2022 · 0 comments
Open

Add tests for gafferpy helper functions #8

t92549 opened this issue Aug 4, 2022 · 0 comments
Labels

Comments

@t92549
Copy link
Contributor

t92549 commented Aug 4, 2022

Tests should be added that assert helper functions still work for backwards compatibility.

Background

A lot of Operations in gafferpy have inner helper functions that make them easier to use.

For example, the following code wraps your inputs into a list of ElementSeeds:
https://github.com/gchq/gaffer-tools/blob/45f5fd1920bf5b93459f16df097224c1c2d0ed50/python-shell/src/gafferpy/gaffer_operations.py#L1123-L1136

This means you could provide an input of 1, but it will be wrapped as:
[{"class": "uk.gov.gchq.gaffer.operation.data.EntitySeed", "vertex": 1}]

These core Operations will now be generated and by default these helper functions will not be generated.

Therefore, there needs to be more tests to assert that the helper functions still work for backwards compatibility, so where they are missing they can be added to the generator code.

@t92549 t92549 added the testing label Aug 4, 2022
@t92549 t92549 transferred this issue from gchq/gaffer-tools Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant